Skip to content

chore: Update PR template format #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

chore: Update PR template format #6077

merged 1 commit into from
Jan 28, 2025

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Jan 28, 2025 •
edited by pr-codex bot
Loading

PR-Codex overview

This PR updates the pull request template in .github/pull_request_template.md to provide clearer instructions for contributors on how to title their PRs and what information to include for reviewers.

Detailed summary

  • Changed the title section to a comment format for clarity.
  • Added instructions for titling PRs with the format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes".
  • Included sections for reviewer notes and testing instructions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:14am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:14am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:14am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 0:14am

@changeset-bot
Copy link

changeset-bot bot commented Jan 28, 2025

⚠️ No Changeset found

Latest commit: c542871

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges Graphite App
Copy link
Member Author

joaquim-verges commented Jan 28, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review January 28, 2025 00:12
@joaquim-verges joaquim-verges merged commit 19ec571 into main Jan 28, 2025
26 of 32 checks passed
@joaquim-verges joaquim-verges deleted the chore_Update_PR_template_format branch January 28, 2025 00:13
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 938 ms (0%) 317 ms (+30.92% 🔺) 1.3 s
thirdweb (cjs) 123.65 KB (0%) 2.5 s (0%) 723 ms (-3.3% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.59 KB (0%) 112 ms (0%) 68 ms (+107.35% 🔺) 180 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 12 ms (+218.96% 🔺) 22 ms
thirdweb/react (minimal + tree-shaking) 19.08 KB (0%) 382 ms (0%) 104 ms (+56.42% 🔺) 486 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls jnsdls is a code owner

Assignees

@joaquim-verges joaquim-verges

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joaquim-verges